Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge to master for v0.9.11 #86

Merged
merged 39 commits into from
Jul 14, 2024
Merged

Merge to master for v0.9.11 #86

merged 39 commits into from
Jul 14, 2024

Conversation

oblivioncth
Copy link
Owner

No description provided.

The bloody format of version.txt never stays the same, hopefully the
current regex works for future updates as well.
Taking a shortcut here, see libfp commit for details.
Not required, but hopefully more future-proof.
- Fixes updated Qx downloader dependency
- Fixes pathing oversight with FPGS requring "../" as the value for the
<fpPath> macro within it's arguments
Was assuming flase in a check where when the memory in question is freed
the result will always be true.
Matches FPProxy's renaming to FPGameServer.
Was using QFileInfo::canonicalFilePath() et. al. before actual
filesystem resolution step, which meant that on Linux when forming a
path to something that needs to be swapped from its windows variant
(i.e. bat -> sh) a blank string would be created instead of the initial
path.

Use QDir::cleanPath() along with QFileInfo()::absoluteFilePath() to
obtain the same clean string but without the requirement of the path
actually existing.
Was using sizeof() instead of size().
The button related args were unused.
Utilize maps for some matrix entries (undocummented feature) to greatly
simplify he matricies for builds. Still requires some cruft with the use
of "exclude", but overall the setup is much clearer, readable, and less
prone to error.
Actions: Simply build matricies
Not sure how it worked before this, but Qt 6.7.2 finally makes a hard
check for this.
It seems the proper way to include wayland support is to link the app to
Qt::WaylandClient, which is also a Qt component. So, we include the
component in the find_package() call and ob_add_standard_executable()
takes care of linking to the target automatically when it's available.
@oblivioncth oblivioncth merged commit d246f22 into master Jul 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant