-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge to master for v0.9.11 #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bloody format of version.txt never stays the same, hopefully the current regex works for future updates as well.
Taking a shortcut here, see libfp commit for details.
Not required, but hopefully more future-proof.
- Fixes updated Qx downloader dependency - Fixes pathing oversight with FPGS requring "../" as the value for the <fpPath> macro within it's arguments
Was assuming flase in a check where when the memory in question is freed the result will always be true.
Matches FPProxy's renaming to FPGameServer.
Was using QFileInfo::canonicalFilePath() et. al. before actual filesystem resolution step, which meant that on Linux when forming a path to something that needs to be swapped from its windows variant (i.e. bat -> sh) a blank string would be created instead of the initial path. Use QDir::cleanPath() along with QFileInfo()::absoluteFilePath() to obtain the same clean string but without the requirement of the path actually existing.
Was using sizeof() instead of size().
Previously would cause an error.
The button related args were unused.
Utilize maps for some matrix entries (undocummented feature) to greatly simplify he matricies for builds. Still requires some cruft with the use of "exclude", but overall the setup is much clearer, readable, and less prone to error.
Actions: Simply build matricies
Not sure how it worked before this, but Qt 6.7.2 finally makes a hard check for this.
It seems the proper way to include wayland support is to link the app to Qt::WaylandClient, which is also a Qt component. So, we include the component in the find_package() call and ob_add_standard_executable() takes care of linking to the target automatically when it's available.
Move to FP13 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.